lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 09/16] clk: spear: Remove uninitialized_var() usage
    From
    Date
    Quoting Kees Cook (2020-06-19 20:30:00)
    > Using uninitialized_var() is dangerous as it papers over real bugs[1]
    > (or can in the future), and suppresses unrelated compiler warnings (e.g.
    > "unused variable"). If the compiler thinks it is uninitialized, either
    > simply initialize the variable or make compiler changes. As a precursor
    > to removing[2] this[3] macro[4], initialize "i" to zero. The compiler
    > warning was not a false positive, since clk_pll_set_rate()'s call to
    > clk_pll_round_rate_index() will always fail (since "prate" is NULL), so
    > "i" was never being initialized.
    >
    > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
    > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
    > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
    > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
    >
    > Fixes: 7d4998f71b29 ("clk: SPEAr: Vco-pll: Fix compilation warning")
    > Signed-off-by: Kees Cook <keescook@chromium.org>
    > ---

    Acked-by: Stephen Boyd <sboyd@kernel.org>

    \
     
     \ /
      Last update: 2020-06-22 11:04    [W:3.614 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site