lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mailbox: imx: Mark PM functions as __maybe_unused
Date
> From: Nathan Chancellor <natechancellor@gmail.com>
> Sent: Tuesday, June 23, 2020 9:04 AM
>
> When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings
> occur:
>
> drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume'
> defined but not used [-Wunused-function]
> 638 | static int imx_mu_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend'
> defined but not used [-Wunused-function]
> 629 | static int imx_mu_runtime_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq'
> defined but not used [-Wunused-function]
> 611 | static int imx_mu_resume_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~
> drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq'
> defined but not used [-Wunused-function]
> 601 | static int imx_mu_suspend_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
>
> Mark these functions as __maybe_unused, which is the standard procedure for
> PM functions.
>
> Fixes: bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU
> clocks")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Thanks for catching this.

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Aisheng
\
 
 \ /
  Last update: 2020-06-23 04:15    [W:0.036 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site