lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 07/23] rcutorture: NULL rcu_torture_current earlier in cleanup code
    Date
    From: "Paul E. McKenney" <paulmck@kernel.org>

    Currently, the rcu_torture_current variable remains non-NULL until after
    all readers have stopped. During this time, rcu_torture_stats_print()
    will think that the test is still ongoing, which can result in confusing
    dmesg output. This commit therefore NULLs rcu_torture_current immediately
    after the rcu_torture_writer() kthread has decided to stop, thus informing
    rcu_torture_stats_print() much sooner.

    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    ---
    kernel/rcu/rcutorture.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
    index 2621a33..5911207 100644
    --- a/kernel/rcu/rcutorture.c
    +++ b/kernel/rcu/rcutorture.c
    @@ -1172,6 +1172,7 @@ rcu_torture_writer(void *arg)
    WARN(1, "%s: rtort_pipe_count: %d\n", __func__, rcu_tortures[i].rtort_pipe_count);
    }
    } while (!torture_must_stop());
    + rcu_torture_current = NULL; // Let stats task know that we are done.
    /* Reset expediting back to unexpedited. */
    if (expediting > 0)
    expediting = -expediting;
    @@ -2473,7 +2474,6 @@ rcu_torture_cleanup(void)
    reader_tasks[i]);
    kfree(reader_tasks);
    }
    - rcu_torture_current = NULL;

    if (fakewriter_tasks) {
    for (i = 0; i < nfakewriters; i++) {
    --
    2.9.5
    \
     
     \ /
      Last update: 2020-06-23 02:39    [W:4.886 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site