lkml.org 
[lkml]   [2020]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] dmaengine: tegra210-adma: Fix runtime PM imbalance on error
From
Date
I propose to combine two tags in the previous patch subject.


> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.

* Can an imperative wording be nicer for the change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=64677779e8962c20b580b471790fe42367750599#n151

* Would you like to add the tag “Fixes” to the commit message?


> ---
> drivers/dma/tegra210-adma.c | 5 ++++-

I find it nicer to replace the triple dashes before this diffstat
by a blank line.

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-21 12:51    [W:0.026 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site