Messages in this thread | | | Subject | Re: [PATCH v4] dmaengine: tegra210-adma: Fix runtime PM imbalance on error | From | Markus Elfring <> | Date | Sun, 21 Jun 2020 12:50:28 +0200 |
| |
I propose to combine two tags in the previous patch subject.
> pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced.
* Can an imperative wording be nicer for the change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=64677779e8962c20b580b471790fe42367750599#n151
* Would you like to add the tag “Fixes” to the commit message?
> --- > drivers/dma/tegra210-adma.c | 5 ++++-
I find it nicer to replace the triple dashes before this diffstat by a blank line.
Regards, Markus
| |