lkml.org 
[lkml]   [2020]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] crypto: ccree: fix resource leak on error path
From
Date
> Fix a small resource leak on the error path of cipher processing.

Would you like to add the tag “Fixes” to the commit message?



> +++ b/drivers/crypto/ccree/cc_cipher.c

> @@ -190,21 +198,19 @@ static int cc_cipher_init(struct crypto_tfm *tfm)

> - return rc;
> +out_key:
> + kfree(ctx_p->user.key);
> +out_shash:
> + crypto_free_shash(ctx_p->shash_tfm);


How do you think about to replace the prefix “out” by “free” in these labels?

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-21 11:29    [W:0.028 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site