Messages in this thread | | | Subject | Re: [PATCH 1/3] crypto: ccree: fix resource leak on error path | From | Markus Elfring <> | Date | Sun, 21 Jun 2020 11:28:00 +0200 |
| |
> Fix a small resource leak on the error path of cipher processing.
Would you like to add the tag “Fixes” to the commit message?
… > +++ b/drivers/crypto/ccree/cc_cipher.c … > @@ -190,21 +198,19 @@ static int cc_cipher_init(struct crypto_tfm *tfm) … > - return rc; > +out_key: > + kfree(ctx_p->user.key); > +out_shash: > + crypto_free_shash(ctx_p->shash_tfm); …
How do you think about to replace the prefix “out” by “free” in these labels?
Regards, Markus
| |