Messages in this thread | | | Date | Sun, 21 Jun 2020 11:57:55 +0300 | From | Ido Schimmel <> | Subject | Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices |
| |
On Sat, Jun 20, 2020 at 03:56:39PM +0300, Vadym Kochan wrote: > But it will look same as prestera_destroy_ports(), do you think > this is not a problem to have a same logic doubled ?
No, error paths of init() usually share logic with fini(). The benefits of being consistent, always having init() followed by fini() and making sure they are symmetric, out-weigh the benefit of saving a few lines of code.
| |