Messages in this thread | | | Date | Sun, 21 Jun 2020 00:09:53 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v3 3/6] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block |
| |
On Wed 17 Jun 11:02 PDT 2020, Wesley Cheng wrote:
> The PM8150B has a dedicated USB type C block, which can be used for type C > orientation and role detection. Create the reference node to this type C > block for further use. > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > index 322379d5c31f..ec44a8bc2f84 100644 > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi > @@ -22,6 +22,14 @@ power-on@800 { > status = "disabled"; > }; > > + qcom,typec@1500 {
Please no "qcom," in the node names and please give it a label to make it easy to change the status of the node.
> + compatible = "qcom,pm8150b-usb-typec"; > + status = "disabled"; > + reg = <0x1500>; > + interrupts = > + <0x2 0x15 0x5 IRQ_TYPE_EDGE_RISING>;
This is nicer on a single line, so please omit the line break.
Regards, Bjorn
> + }; > + > adc@3100 { > compatible = "qcom,spmi-adc5"; > reg = <0x3100>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
| |