Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] fat: add a check to fat_add_new_entries | Date | Mon, 22 Jun 2020 02:50:44 +0900 |
| |
trix@redhat.com writes:
> start_blknr = blknr = fat_clus_to_blknr(sbi, cluster[i]); > last_blknr = start_blknr + sbi->sec_per_clus; > + > + /* overflow */ > + if (unlikely(last_blknr <= start_blknr)) { > + err = -ENOMEM; > + goto error_nomem; > + } > +
The cluster is 28bits and sec_per_clus is 8bits, so this should never overflow actually. Is there no way to tell it to clang?
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |