Messages in this thread | | | Subject | Re: [PATCH v2] drm/amdkfd: Fix memory leaks according to error branches | From | Markus Elfring <> | Date | Sat, 20 Jun 2020 11:20:24 +0200 |
| |
> The function kobject_init_and_add alloc memory like: > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller > ->kmalloc_slab, in err branch this memory not free. If use > kmemleak, this path maybe catched. > These changes are to add kobject_put in kobject_init_and_add > failed branch, fix potential memleak.
I suggest to improve this change description.
* Can an other wording variant be nicer?
* Will the tag “Fixes” become helpful for the commit message?
Regards, Markus
| |