Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support | From | Yingjoe Chen <> | Date | Sat, 20 Jun 2020 15:45:54 +0800 |
| |
Sorry for late review.
On Thu, 2020-05-14 at 21:09 +0800, Qii Wang wrote: > This patch adds a algorithm to calculate some ac-timing parameters > which can fully meet I2C Spec. > > Signed-off-by: Qii Wang <qii.wang@mediatek.com> > --- > drivers/i2c/busses/i2c-mt65xx.c | 328 +++++++++++++++++++++++++++++++++------- > 1 file changed, 277 insertions(+), 51 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > index 0ca6c38a..7020618 100644 > --- a/drivers/i2c/busses/i2c-mt65xx.c > +++ b/drivers/i2c/busses/i2c-mt65xx.c
<...>
> @@ -948,9 +1177,6 @@ static int mtk_i2c_probe(struct platform_device *pdev) > if (ret) > return -EINVAL; > > - if (i2c->dev_comp->timing_adjust) > - i2c->clk_src_div *= I2C_DEFAULT_CLK_DIV; > -
After this patch, the 'clock-div' property in device tree is no longer used for platform with timing_adjust ability. Please change the binding, so we don't need to provide 'clock-div' for these platform.
Joe.C
> if (i2c->have_pmic && !i2c->dev_comp->pmic_i2c) > return -EINVAL; >
| |