Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 20 Jun 2020 11:58:13 -0700 | Subject | Re: [PATCH 1/2] exec: Don't set group_exit_task during a coredump |
| |
On Fri, Jun 19, 2020 at 11:36 AM Eric W. Biederman <ebiederm@xmission.com> wrote: > > Instead test SIGNAL_GROUP_COREDUMP in signal_group_exit().
You say "instead", but the patch itself doesn't agree:
> static inline int signal_group_exit(const struct signal_struct *sig) > { > - return (sig->flags & SIGNAL_GROUP_EXIT) || > + return (sig->flags & (SIGNAL_GROUP_EXIT | SIGNAL_GROUP_COREDUMP)) || > (sig->group_exit_task != NULL); > }
it does it _in_addition_to_.
I think the whole test for "sig->group_exit_task != NULL" should be removed for this commit to make sense.
Linus
| |