lkml.org 
[lkml]   [2020]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()
On Mon, Jun 1, 2020 at 11:47 PM YueHaibing <yuehaibing@huawei.com> wrote:
> @@ -630,6 +625,9 @@ static int genl_family_rcv_msg_dumpit(const struct genl_family *family,
> err = __netlink_dump_start(net->genl_sock, skb, nlh, &c);
> }
>
> + genl_family_rcv_msg_attrs_free(info->family, info->attrs, true);
> + genl_dumpit_info_free(info);
> +
> return err;
> }

I do not think you can just move it after __netlink_dump_start(),
because cb->done() can be called, for example, in netlink_sock_destruct()
too.

\
 
 \ /
  Last update: 2020-06-02 20:06    [W:0.055 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site