lkml.org 
[lkml]   [2020]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/4] selftests, sysctl, lib: Fix prime_numbers and sysctl test to run
From
Date
On 5/29/20 8:39 AM, Masami Hiramatsu wrote:
> On Fri, 29 May 2020 08:14:39 -0600
> Shuah Khan <skhan@linuxfoundation.org> wrote:
>
>> On 5/28/20 8:51 AM, Masami Hiramatsu wrote:
>>> Hi,
>>>
>>> Recently, I found some tests were always skipped.
>>> Here is a series of patches to fix those issues.
>>>
>>> The prime_numbers test is skipped in some cases because
>>> prime_numbers.ko is not always compiled.
>>> Since the CONFIG_PRIME_NUMBERS is not independently
>>> configurable item (it has no title and help), it is enabled
>>> only if other configs (DRM_DEBUG_SELFTEST etc.) select it.
>>>
>>> To fix this issue, I added a title and help for
>>> CONFIG_PRIME_NUMBERS.
>>>
>>> The sysctl test is skipped because
>>> - selftests/sysctl/config requires CONFIG_TEST_SYSCTL=y. But
>>> since lib/test_sysctl.c doesn't use module_init(), the
>>> test_syscall is not listed under /sys/module/ and the
>>> test script gives up.
>>> - Even if we make CONFIG_TEST_SYSCTL=m, the test script checks
>>> /sys/modules/test_sysctl before loading module and gives up.
>>> - Ayway, since the test module introduces useless sysctl
>>> interface to the kernel, it would better be a module.
>>>
>>> This series includes fixes for above 3 points.
>>> - Fix lib/test_sysctl.c to use module_init()
>>> - Fix tools/testing/selftests/sysctl/sysctl.sh to try to load
>>> test module if it is not loaded (nor embedded).
>>> - Fix tools/testing/selftests/sysctl/config to require
>>> CONFIG_TEST_SYSCTL=m, not y.
>>>
>>> Thank you,
>>>
>>> ---
>>>
>>> Masami Hiramatsu (4):
>>> lib: Make prime number generator independently selectable
>>> lib: Make test_sysctl initialized as module
>>> selftests/sysctl: Fix to load test_sysctl module
>>> selftests/sysctl: Make sysctl test driver as a module
>>>
>>>
>>> lib/math/Kconfig | 7 ++++++-
>>> lib/test_sysctl.c | 2 +-
>>> tools/testing/selftests/sysctl/config | 2 +-
>>> tools/testing/selftests/sysctl/sysctl.sh | 13 ++-----------
>>> 4 files changed, 10 insertions(+), 14 deletions(-)
>>>
>>> --
>>> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
>>>
>>
>> Thanks Masami. I see Kees reviewing patches. I will wait for Luis to
>> weigh in on patch 2 before pulling this series in.
>
> OK, Thanks Shuah!
>
>

Applied to linux-kselftest next for Linux 5.8-rc1.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-06-02 18:33    [W:0.064 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site