Messages in this thread | | | Subject | Re: [PATCH] cxl: Fix kobject memleak | From | Frederic Barrat <> | Date | Tue, 2 Jun 2020 18:21:13 +0200 |
| |
Le 02/06/2020 à 14:07, Wang Hai a écrit : > Currently the error return path from kobject_init_and_add() is not > followed by a call to kobject_put() - which means we are leaking > the kobject. > > Fix it by adding a call to kobject_put() in the error path of > kobject_init_and_add(). > > Fixes: b087e6190ddc ("cxl: Export optional AFU configuration record in sysfs") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wang Hai <wanghai38@huawei.com>
Indeed, a call to kobject_put() is needed when the init fails. Thanks! Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> --- > drivers/misc/cxl/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c > index f0263d1..d97a243 100644 > --- a/drivers/misc/cxl/sysfs.c > +++ b/drivers/misc/cxl/sysfs.c > @@ -624,7 +624,7 @@ static struct afu_config_record *cxl_sysfs_afu_new_cr(struct cxl_afu *afu, int c > rc = kobject_init_and_add(&cr->kobj, &afu_config_record_type, > &afu->dev.kobj, "cr%i", cr->cr); > if (rc) > - goto err; > + goto err1; > > rc = sysfs_create_bin_file(&cr->kobj, &cr->config_attr); > if (rc) >
| |