lkml.org 
[lkml]   [2020]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate
On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz
<piotr.stankiewicz@intel.com> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.

...

> - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI;
> + unsigned int flags = PCI_IRQ_MSI_TYPES;
>
> if (!pci_is_pcie(dd->pcidev)) {
> qib_dev_err(dd, "Can't find PCI Express capability!\n");

Internally I have proposed at last this:

convert the following
if (dd->flags & QIB_HAS_INTX)
flags |= PCI_IRQ_LEGACY;

to
if (dd->flags & QIB_HAS_INTX)
flags = PCI_IRQ_ALL_TYPES;
if (dd->flags & QIB_HAS_INTX)
flags = PCI_IRQ_MSI_TYPES;

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-06-02 17:36    [W:0.037 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site