lkml.org 
[lkml]   [2020]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
    On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote:
    > Currently, GB codec and audio module is conditionally compiled based on
    > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994
    > platform and can be used generically with any platform that follows
    > GB Audio class specification.
    >
    > Also, GB codec driver corresponds to dummy codec represented by I2S port
    > available on Toshiba AP Bridge. Added config option for the same in
    > kconfig file and accordingly updated Makefile.
    >

    This commit message was a bit confusing to me. Just say:

    "Currently you can't enable the Grey Bus Audio Codec because there is no
    entry for it in the Kconfig file. Originally the config name was going
    to be AUDIO_MSM8994 but that's not correct because other types of
    hardware are supported now. I have chosen the name AUDIO_APB_CODEC
    instead. Also I had to update the dependencies for GREYBUS_AUDIO to
    make the compile work."

    Otherwise this looks fine.

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2020-06-02 14:59    [W:2.290 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site