Messages in this thread | | | Subject | Re: [PATCH] spi: img-spfi: Add missing pm_runtime_put() call in img_spfi_resume() | From | Markus Elfring <> | Date | Tue, 2 Jun 2020 11:30:13 +0200 |
| |
Please avoid a typo in the patch subject (by a possible alternative?).
> Call to pm_runtime_get_sync increments counter even in case of > failure leading to incorrect ref count. > Call pm_runtime_put if pm_runtime_get_sync fails.
How do you think about a wording variant like the following?
Change description: The PM runtime reference counter is generally incremented by a call of the function “pm_runtime_get_sync”. Thus call the function “pm_runtime_put” also in one error case to keep the reference counting consistent.
Would you like to add the tag “Fixes” to the commit message?
Regards, Markus
| |