lkml.org 
[lkml]   [2020]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/5] PCI: uniphier: Add iATU register support
From
Date
Hi Rob,

On 2020/06/02 6:32, Rob Herring wrote:
> On Fri, May 15, 2020 at 06:59:02PM +0900, Kunihiko Hayashi wrote:
>> This gets iATU register area from reg property. In Synopsis DWC version
>> 4.80 or later, since iATU register area is separated from core register
>> area, this area is necessary to get from DT independently.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> drivers/pci/controller/dwc/pcie-uniphier.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c
>> index a8dda39..493f105 100644
>> --- a/drivers/pci/controller/dwc/pcie-uniphier.c
>> +++ b/drivers/pci/controller/dwc/pcie-uniphier.c
>> @@ -447,6 +447,13 @@ static int uniphier_pcie_probe(struct platform_device *pdev)
>> if (IS_ERR(priv->pci.dbi_base))
>> return PTR_ERR(priv->pci.dbi_base);
>>
>> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu");
>> + if (res) {
>> + priv->pci.atu_base = devm_pci_remap_cfg_resource(dev, res);
>
> This isn't config space, so this function shouldn't be used.
>
> Use devm_platform_ioremap_resource_byname().

Indeed. I'll replace with it.

>> + if (IS_ERR(priv->pci.atu_base))
>> + priv->pci.atu_base = NULL;
>> + }
>> +
>> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link");
>> priv->base = devm_ioremap_resource(dev, res);
>
> Feel free to convert this one too.

This should be replaced as well.

Thank you,

---
Best Regards
Kunihiko Hayashi

\
 
 \ /
  Last update: 2020-06-02 11:08    [W:0.064 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site