lkml.org 
[lkml]   [2020]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio_probe()
From
Date
On 2020/6/3 9:35, yu kuai wrote:
> A coccicheck run provided information like the following:
>
> drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 792, but without a corresponding
> object release within this function.
>
> Generated by: scripts/coccinelle/free/put_device.cocci
>
> Thus add a jump target to fix the exception handling for this
> function implementation.
>
> Fixes: 5130216265f6 ("PINCTRL: SiRF: add GPIO and GPIO irq support in CSR SiRFprimaII")
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/pinctrl/sirf/pinctrl-sirf.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
Sorry about the missing change log:

Changes in V2:
change the variant of commit message suggested by Markus.

Best Regards,
Yu Kuai

\
 
 \ /
  Last update: 2020-06-03 03:40    [W:0.038 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site