Messages in this thread | | | Subject | Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed | From | "Martin K. Petersen" <> | Date | Tue, 02 Jun 2020 18:35:10 -0400 |
| |
Hi Yu!
I suggest a few minor wording tweaks to the commit message:
> commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add
s/add/added/
> a kree() for 'buf' if bio_integrity_add_page() return '0'. However, > the
s/kree/kfree/ s/return/returns/
> object will be freed in bio_integrity_free() since 'bio->bi_opf' and > 'bio->bi_integrity' was set previousy in bio_integrity_alloc().
s/was/were/
Otherwise OK.
And like Ming pointed out, you may want to add a comment about the assertion that the first vec is valid.
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
-- Martin K. Petersen Oracle Linux Engineering
| |