lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 058/267] spi: No need to assign dummy value in spi_unregister_controller()
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    [ Upstream commit ebc37af5e0a134355ea2b62ed4141458bdbd5389 ]

    The device_for_each_child() doesn't require the returned value to be checked.
    Thus, drop the dummy variable completely and have no warning anymore:

    drivers/spi/spi.c: In function ‘spi_unregister_controller’:
    drivers/spi/spi.c:2480:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
    int dummy;
    ^~~~~

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
    index 88a8a8edd44b..0022a49797f9 100644
    --- a/drivers/spi/spi.c
    +++ b/drivers/spi/spi.c
    @@ -2305,7 +2305,6 @@ void spi_unregister_controller(struct spi_controller *ctlr)
    {
    struct spi_controller *found;
    int id = ctlr->bus_num;
    - int dummy;

    /* First make sure that this controller was ever added */
    mutex_lock(&board_lock);
    @@ -2319,7 +2318,7 @@ void spi_unregister_controller(struct spi_controller *ctlr)
    list_del(&ctlr->list);
    mutex_unlock(&board_lock);

    - dummy = device_for_each_child(&ctlr->dev, NULL, __unregister);
    + device_for_each_child(&ctlr->dev, NULL, __unregister);
    device_unregister(&ctlr->dev);
    /* free bus id */
    mutex_lock(&board_lock);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 16:58    [W:3.965 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site