Messages in this thread | | | Date | Fri, 19 Jun 2020 11:46:18 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH -next] RDMA/rtrs: fix potential resources leaks |
| |
On Fri, Jun 19, 2020 at 03:16:57PM +0200, Jinpu Wang wrote: > Hi, Bo, > On Fri, Jun 19, 2020 at 3:10 PM Bo YU <tsu.yubo@gmail.com> wrote: > > > > Dev is returned from allocation function kzalloc but it does not > > free it in out_err path. > If allocation failed, kzalloc return NULL, nothing to free.
You should re-organize this to not confuse coverity.
IS_ERR_OR_NULL should rarely be used and is the problem here
Jason
| |