lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 023/190] ALSA: es1688: Add the missed snd_card_free()
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    commit d9b8fbf15d05350b36081eddafcf7b15aa1add50 upstream.

    snd_es968_pnp_detect() misses a snd_card_free() in a failed path.
    Add the missed function call to fix it.

    Fixes: a20971b201ac ("ALSA: Merge es1688 and es968 drivers")
    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200603092459.1424093-1-hslester96@gmail.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/isa/es1688/es1688.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/sound/isa/es1688/es1688.c
    +++ b/sound/isa/es1688/es1688.c
    @@ -284,8 +284,10 @@ static int snd_es968_pnp_detect(struct p
    return error;
    }
    error = snd_es1688_probe(card, dev);
    - if (error < 0)
    + if (error < 0) {
    + snd_card_free(card);
    return error;
    + }
    pnp_set_card_drvdata(pcard, card);
    snd_es968_pnp_is_probed = 1;
    return 0;

    \
     
     \ /
      Last update: 2020-06-19 16:46    [W:2.837 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site