lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 013/128] efi/efivars: Add missing kobject_put() in sysfs entry creation error path
    Date
    From: Ard Biesheuvel <ardb@kernel.org>

    commit d8bd8c6e2cfab8b78b537715255be8d7557791c0 upstream.

    The documentation provided by kobject_init_and_add() clearly spells out
    the need to call kobject_put() on the kobject if an error is returned.
    Add this missing call to the error path.

    Cc: <stable@vger.kernel.org>
    Reported-by: 亿一 <teroincn@gmail.com>
    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/firmware/efi/efivars.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/firmware/efi/efivars.c
    +++ b/drivers/firmware/efi/efivars.c
    @@ -586,8 +586,10 @@ efivar_create_sysfs_entry(struct efivar_
    ret = kobject_init_and_add(&new_var->kobj, &efivar_ktype,
    NULL, "%s", short_name);
    kfree(short_name);
    - if (ret)
    + if (ret) {
    + kobject_put(&new_var->kobj);
    return ret;
    + }

    kobject_uevent(&new_var->kobj, KOBJ_ADD);
    if (efivar_entry_add(new_var, &efivar_sysfs_list)) {

    \
     
     \ /
      Last update: 2020-06-19 16:40    [W:3.339 / U:1.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site