Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 19 Jun 2020 14:09:15 +0200 | Subject | Re: [PATCH] soc: imx-scu: Support module build |
| |
On Fri, Jun 19, 2020 at 9:40 AM Anson Huang <anson.huang@nxp.com> wrote: > > Subject: RE: [PATCH] soc: imx-scu: Support module build > > > > > From: Arnd Bergmann <arnd@arndb.de> Sent: Thursday, June 18, 2020 3:21 PM > > > I see that there is indeed a driver for the device node in > > > drivers/firmware/imx/imx-scu.c, the only reason for this module using > > > device_initcall() with a manual > > > platform_device_register_simple() seems to be that we cannot have two > > > platform drivers bind to the same device node. > > > > > > I think a cleaner way to handle this would be to just move the entire > > > soc driver into the firmware driver and then remove the duplication. > > > > > > > Yes, sounds like a good idea to me. > > So the idea is to remove this driver and implement the soc id/revision/serial_number etc. > in drivers/firmware/imx/imx-scu.c, right?
Yes, I think you can basically merge imx_scu_soc_probe() into imx_scu_probe() or call it from there, with only a few changes.
Arnd
| |