Messages in this thread | | | Subject | Re: [PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg | From | Divya Indi <> | Date | Fri, 19 Jun 2020 17:43:14 -0700 |
| |
Hi Jason,
Thanks for taking the time to review!
On 6/17/20 11:24 AM, Jason Gunthorpe wrote: > On Tue, Jun 16, 2020 at 10:56:53AM -0700, Divya Indi wrote: >> The other option might be to use GFP_NOWAIT conditionally ie >> (only use GFP_NOWAIT when GFP_ATOMIC is not specified in gfp_mask else >> use GFP_ATOMIC). Eventual goal being to not have a blocking memory allocation. > This is probably safest for now, unless you can audit all callers and > see if they can switch to GFP_NOWAIT as well
At present the callers with GFP_ATOMIC appear to be ipoib. Might not be feasible to change them all to GFP_NOWAIT.
Will incorporate the review comments and send out v3 early next week.
Thanks, Divya
> > Jason
| |