lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/4] ARM: dts: imx6sl: fix rng node
Hi Horia,

On Fri, Jun 19, 2020 at 6:34 PM Horia Geantă <horia.geanta@nxp.com> wrote:
>
> rng DT node was added without a compatible string.
>
> i.MX driver for RNGC (drivers/char/hw_random/imx-rngc.c) also claims
> support for RNGB, and is currently used for i.MX25.
>
> Let's used this driver also for RNGB block in i.MX6SL.

"Let's use"

>
> Fixes: e29fe21cff96 ("ARM: dts: add device tree source for imx6sl SoC")
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> ---
> arch/arm/boot/dts/imx6sl.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 911d8cf77f2c..1f0f250ee175 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -939,8 +939,10 @@
> };
>
> rngb: rngb@21b4000 {
> + compatible = "fsl,imx25-rngb";

Better to use:

compatible = "fsl,imx6sl-rngb","fsl,imx25-rngb";

and document fsl,imx6sl-rngb

\
 
 \ /
  Last update: 2020-06-19 23:47    [W:0.376 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site