lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 4/8] blktrace: annotate required lock on do_blk_trace_setup()
    Date
    Ensure it is clear which lock is required on do_blk_trace_setup().

    Suggested-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
    ---
    kernel/trace/blktrace.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
    index 7f60029bdaff..7ff2ea5cd05e 100644
    --- a/kernel/trace/blktrace.c
    +++ b/kernel/trace/blktrace.c
    @@ -483,6 +483,8 @@ static int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
    struct dentry *dir = NULL;
    int ret;

    + lockdep_assert_held(&q->blk_trace_mutex);
    +
    if (!buts->buf_size || !buts->buf_nr)
    return -EINVAL;

    --
    2.26.2
    \
     
     \ /
      Last update: 2020-06-19 22:50    [W:2.231 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site