lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/21] perf/x86/intel/lbr: Support LBR_CTL
On Fri, Jun 19, 2020 at 07:03:59AM -0700, kan.liang@linux.intel.com wrote:
> - if (x86_pmu.extra_regs || x86_pmu.lbr_sel_map) {
> + if (x86_pmu.extra_regs || x86_pmu.lbr_sel_map || x86_pmu.lbr_ctl_map) {

> + union {
> + u64 lbr_sel_mask; /* LBR_SELECT valid bits */
> + u64 lbr_ctl_mask; /* LBR_CTL valid bits */
> + };

This makes absolutely no sense. There is hoping the compiler realizes
how stupid that is and fixes it for you, but shees.

Please, just keep the old name.

\
 
 \ /
  Last update: 2020-06-19 20:42    [W:0.169 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site