lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 019/128] ACPI: PM: Avoid using power resources if there are none for D0
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    commit 956ad9d98b73f59e442cc119c98ba1e04e94fe6d upstream.

    As recently reported, some platforms provide a list of power
    resources for device power state D3hot, through the _PR3 object,
    but they do not provide a list of power resources for device power
    state D0.

    Among other things, this causes acpi_device_get_power() to return
    D3hot as the current state of the device in question if all of the
    D3hot power resources are "on", because it sees the power_resources
    flag set and calls acpi_power_get_inferred_state() which finds that
    D3hot is the shallowest power state with all of the associated power
    resources turned "on", so that's what it returns. Moreover, that
    value takes precedence over the acpi_dev_pm_explicit_get() return
    value, because it means a deeper power state. The device may very
    well be in D0 physically at that point, however.

    Moreover, the presence of _PR3 without _PR0 for a given device
    means that only one D3-level power state can be supported by it.
    Namely, because there are no power resources to turn "off" when
    transitioning the device from D0 into D3cold (which should be
    supported since _PR3 is present), the evaluation of _PS3 should
    be sufficient to put it straight into D3cold, but this means that
    the effect of turning "on" the _PR3 power resources is unclear,
    so it is better to avoid doing that altogether. Consequently,
    there is no practical way do distinguish D3cold from D3hot for
    the device in question and the power states of it can be labeled
    so that D3hot is the deepest supported one (and Linux assumes
    that putting a device into D3hot via ACPI may cause power to be
    removed from it anyway, for legacy reasons).

    To work around the problem described above modify the ACPI
    enumeration of devices so that power resources are only used
    for device power management if the list of D0 power resources
    is not empty and make it mart D3cold as supported only if that
    is the case and the D3hot list of power resources is not empty
    too.

    Fixes: ef85bdbec444 ("ACPI / scan: Consolidate extraction of power resources lists")
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=205057
    Link: https://lore.kernel.org/linux-acpi/20200603194659.185757-1-hdegoede@redhat.com/
    Reported-by: Hans de Goede <hdegoede@redhat.com>
    Tested-by: Hans de Goede <hdegoede@redhat.com>
    Tested-by: youling257@gmail.com
    Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/acpi/device_pm.c | 2 +-
    drivers/acpi/scan.c | 28 +++++++++++++++++++---------
    2 files changed, 20 insertions(+), 10 deletions(-)

    --- a/drivers/acpi/device_pm.c
    +++ b/drivers/acpi/device_pm.c
    @@ -171,7 +171,7 @@ int acpi_device_set_power(struct acpi_de
    * possibly drop references to the power resources in use.
    */
    state = ACPI_STATE_D3_HOT;
    - /* If _PR3 is not available, use D3hot as the target state. */
    + /* If D3cold is not supported, use D3hot as the target state. */
    if (!device->power.states[ACPI_STATE_D3_COLD].flags.valid)
    target_state = state;
    } else if (!device->power.states[state].flags.valid) {
    --- a/drivers/acpi/scan.c
    +++ b/drivers/acpi/scan.c
    @@ -927,12 +927,9 @@ static void acpi_bus_init_power_state(st

    if (buffer.length && package
    && package->type == ACPI_TYPE_PACKAGE
    - && package->package.count) {
    - int err = acpi_extract_power_resources(package, 0,
    - &ps->resources);
    - if (!err)
    - device->power.flags.power_resources = 1;
    - }
    + && package->package.count)
    + acpi_extract_power_resources(package, 0, &ps->resources);
    +
    ACPI_FREE(buffer.pointer);
    }

    @@ -979,14 +976,27 @@ static void acpi_bus_get_power_flags(str
    acpi_bus_init_power_state(device, i);

    INIT_LIST_HEAD(&device->power.states[ACPI_STATE_D3_COLD].resources);
    - if (!list_empty(&device->power.states[ACPI_STATE_D3_HOT].resources))
    - device->power.states[ACPI_STATE_D3_COLD].flags.valid = 1;

    - /* Set defaults for D0 and D3hot states (always valid) */
    + /* Set the defaults for D0 and D3hot (always supported). */
    device->power.states[ACPI_STATE_D0].flags.valid = 1;
    device->power.states[ACPI_STATE_D0].power = 100;
    device->power.states[ACPI_STATE_D3_HOT].flags.valid = 1;

    + /*
    + * Use power resources only if the D0 list of them is populated, because
    + * some platforms may provide _PR3 only to indicate D3cold support and
    + * in those cases the power resources list returned by it may be bogus.
    + */
    + if (!list_empty(&device->power.states[ACPI_STATE_D0].resources)) {
    + device->power.flags.power_resources = 1;
    + /*
    + * D3cold is supported if the D3hot list of power resources is
    + * not empty.
    + */
    + if (!list_empty(&device->power.states[ACPI_STATE_D3_HOT].resources))
    + device->power.states[ACPI_STATE_D3_COLD].flags.valid = 1;
    + }
    +
    if (acpi_bus_init_power(device))
    device->flags.power_manageable = 0;
    }

    \
     
     \ /
      Last update: 2020-06-19 18:49    [W:6.436 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site