lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 087/267] agp/intel: Reinforce the barrier after GTT updates
    Date
    From: Chris Wilson <chris@chris-wilson.co.uk>

    commit f30d3ced9fafa03e4855508929b5b6334907f45e upstream.

    After changing the timing between GTT updates and execution on the GPU,
    we started seeing sporadic failures on Ironlake. These were narrowed
    down to being an insufficiently strong enough barrier/delay after
    updating the GTT and scheduling execution on the GPU. By forcing the
    uncached read, and adding the missing barrier for the singular
    insert_page (relocation paths), the sporadic failures go away.

    Fixes: 983d308cb8f6 ("agp/intel: Serialise after GTT updates")
    Fixes: 3497971a71d8 ("agp/intel: Flush chipset writes after updating a single PTE")
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Acked-by: Andi Shyti <andi.shyti@intel.com>
    Cc: stable@vger.kernel.org # v4.0+
    Link: https://patchwork.freedesktop.org/patch/msgid/20200410083535.25464-1-chris@chris-wilson.co.uk
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/char/agp/intel-gtt.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/char/agp/intel-gtt.c
    +++ b/drivers/char/agp/intel-gtt.c
    @@ -846,6 +846,7 @@ void intel_gtt_insert_page(dma_addr_t ad
    unsigned int flags)
    {
    intel_private.driver->write_entry(addr, pg, flags);
    + readl(intel_private.gtt + pg);
    if (intel_private.driver->chipset_flush)
    intel_private.driver->chipset_flush();
    }
    @@ -871,7 +872,7 @@ void intel_gtt_insert_sg_entries(struct
    j++;
    }
    }
    - wmb();
    + readl(intel_private.gtt + j - 1);
    if (intel_private.driver->chipset_flush)
    intel_private.driver->chipset_flush();
    }
    @@ -1105,6 +1106,7 @@ static void i9xx_cleanup(void)

    static void i9xx_chipset_flush(void)
    {
    + wmb();
    if (intel_private.i9xx_flush_page)
    writel(1, intel_private.i9xx_flush_page);
    }

    \
     
     \ /
      Last update: 2020-06-19 18:26    [W:4.069 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site