Messages in this thread | | | Subject | Re: [RFC PATCH ] scsi: remove scsi_sdb_cache | From | Bean Huo <> | Date | Fri, 19 Jun 2020 17:03:47 +0200 |
| |
Hi Bart
Thanks.
On Fri, 2020-06-19 at 07:31 -0700, Bart Van Assche wrote: > On 2020-06-19 06:10, Bean Huo wrote: > > @@ -2039,7 +2024,6 @@ scsi_mode_select(struct scsi_device *sdev, > > int pf, int sp, int modepage, > > real_buffer[1] = data->medium_type; > > real_buffer[2] = data->device_specific; > > real_buffer[3] = data->block_descriptor_length; > > - Here delete a blank line since there are multiple blank lines. > > > > > > cmd[0] = MODE_SELECT; > > cmd[4] = len; > > @@ -2227,7 +2211,7 @@ scsi_device_set_state(struct scsi_device > > *sdev, enum scsi_device_state state) > > goto illegal; > > } > > break; > > - > > +
Here has trailing whitespace, delete it.
> > case SDEV_RUNNING: > > switch (oldstate) { > > case SDEV_CREATED: > > If these whitespace changes are left out, feel free to add: > > Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Bean
| |