lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 075/261] dpaa2-eth: fix return codes used in ndo_setup_tc
    Date
    From: Jesper Dangaard Brouer <brouer@redhat.com>

    [ Upstream commit b89c1e6bdc73f5775e118eb2ab778e75b262b30c ]

    Drivers ndo_setup_tc call should return -EOPNOTSUPP, when it cannot
    support the qdisc type. Other return values will result in failing the
    qdisc setup. This lead to qdisc noop getting assigned, which will
    drop all TX packets on the interface.

    Fixes: ab1e6de2bd49 ("dpaa2-eth: Add mqprio support")
    Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
    Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
    index a935b20effa3..3177dd8ede8e 100644
    --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
    +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
    @@ -1981,7 +1981,7 @@ static int dpaa2_eth_setup_tc(struct net_device *net_dev,
    int i;

    if (type != TC_SETUP_QDISC_MQPRIO)
    - return -EINVAL;
    + return -EOPNOTSUPP;

    mqprio->hw = TC_MQPRIO_HW_OFFLOAD_TCS;
    num_queues = dpaa2_eth_queue_count(priv);
    @@ -1993,7 +1993,7 @@ static int dpaa2_eth_setup_tc(struct net_device *net_dev,
    if (num_tc > dpaa2_eth_tc_count(priv)) {
    netdev_err(net_dev, "Max %d traffic classes supported\n",
    dpaa2_eth_tc_count(priv));
    - return -EINVAL;
    + return -EOPNOTSUPP;
    }

    if (!num_tc) {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 18:08    [W:2.903 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site