lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 116/376] netfilter: nft_nat: return EOPNOTSUPP if type or flags are not supported
    Date
    From: Pablo Neira Ayuso <pablo@netfilter.org>

    [ Upstream commit 0d7c83463fdf7841350f37960a7abadd3e650b41 ]

    Instead of EINVAL which should be used for malformed netlink messages.

    Fixes: eb31628e37a0 ("netfilter: nf_tables: Add support for IPv6 NAT")
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/netfilter/nft_nat.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/net/netfilter/nft_nat.c b/net/netfilter/nft_nat.c
    index 8b44a4de5329..bb49a217635e 100644
    --- a/net/netfilter/nft_nat.c
    +++ b/net/netfilter/nft_nat.c
    @@ -129,7 +129,7 @@ static int nft_nat_init(const struct nft_ctx *ctx, const struct nft_expr *expr,
    priv->type = NF_NAT_MANIP_DST;
    break;
    default:
    - return -EINVAL;
    + return -EOPNOTSUPP;
    }

    if (tb[NFTA_NAT_FAMILY] == NULL)
    @@ -196,7 +196,7 @@ static int nft_nat_init(const struct nft_ctx *ctx, const struct nft_expr *expr,
    if (tb[NFTA_NAT_FLAGS]) {
    priv->flags = ntohl(nla_get_be32(tb[NFTA_NAT_FLAGS]));
    if (priv->flags & ~NF_NAT_RANGE_MASK)
    - return -EINVAL;
    + return -EOPNOTSUPP;
    }

    return nf_ct_netns_get(ctx->net, family);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 17:53    [W:4.228 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site