Messages in this thread | | | Date | Fri, 19 Jun 2020 00:47:38 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n" |
| |
On Fri, Jun 19, 2020 at 01:48:23PM +0900, Masahiro Yamada wrote: > This reverts commit e0b250b57dcf403529081e5898a9de717f96b76b. > > Now that "make install" copies modules.builtin to $(INSTALL_MOD_PATH), > it breaks systems that do not set INSTALL_MOD_PATH for "make install". > > While modules.builtin is useful for CONFIG_MODULES=n, this way gives > unexpected impact to existing systems. Maybe "make modules_install" > can install modules.builtin irrespective of CONFIG_MODULES as Jonas > originally suggested. Anyway, this commit should be reverted ASAP.
What is the "unexpected impact? This commit log needs to explain that.
| |