lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 007/261] crypto: ccp -- dont "select" CONFIG_DMADEVICES
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit eebac678556d6927f09a992872f4464cf3aecc76 ]

    DMADEVICES is the top-level option for the slave DMA
    subsystem, and should not be selected by device drivers,
    as this can cause circular dependencies such as:

    drivers/net/ethernet/freescale/Kconfig:6:error: recursive dependency detected!
    drivers/net/ethernet/freescale/Kconfig:6: symbol NET_VENDOR_FREESCALE depends on PPC_BESTCOMM
    drivers/dma/bestcomm/Kconfig:6: symbol PPC_BESTCOMM depends on DMADEVICES
    drivers/dma/Kconfig:6: symbol DMADEVICES is selected by CRYPTO_DEV_SP_CCP
    drivers/crypto/ccp/Kconfig:10: symbol CRYPTO_DEV_SP_CCP depends on CRYPTO
    crypto/Kconfig:16: symbol CRYPTO is selected by LIBCRC32C
    lib/Kconfig:222: symbol LIBCRC32C is selected by LIQUIDIO
    drivers/net/ethernet/cavium/Kconfig:65: symbol LIQUIDIO depends on PTP_1588_CLOCK
    drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by FEC
    drivers/net/ethernet/freescale/Kconfig:23: symbol FEC depends on NET_VENDOR_FREESCALE

    The LIQUIDIO driver causing this problem is addressed in a
    separate patch, but this change is needed to prevent it from
    happening again.

    Using "depends on DMADEVICES" is what we do for all other
    implementations of slave DMA controllers as well.

    Fixes: b3c2fee5d66b ("crypto: ccp - Ensure all dependencies are specified")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/ccp/Kconfig | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
    index 8fec733f567f..63e227adbb13 100644
    --- a/drivers/crypto/ccp/Kconfig
    +++ b/drivers/crypto/ccp/Kconfig
    @@ -10,10 +10,9 @@ config CRYPTO_DEV_CCP_DD
    config CRYPTO_DEV_SP_CCP
    bool "Cryptographic Coprocessor device"
    default y
    - depends on CRYPTO_DEV_CCP_DD
    + depends on CRYPTO_DEV_CCP_DD && DMADEVICES
    select HW_RANDOM
    select DMA_ENGINE
    - select DMADEVICES
    select CRYPTO_SHA1
    select CRYPTO_SHA256
    help
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 17:25    [W:4.018 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site