lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 247/261] mtd: rawnand: orion: Fix the probe error path
    Date
    From: Miquel Raynal <miquel.raynal@bootlin.com>

    commit be238fbf78e4c7c586dac235ab967d3e565a4d1a upstream.

    nand_release() is supposed be called after MTD device registration.
    Here, only nand_scan() happened, so use nand_cleanup() instead.

    There is no real Fixes tag applying here as the use of nand_release()
    in this driver predates by far the introduction of nand_cleanup() in
    commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
    which makes this change possible. However, pointing this commit as the
    culprit for backporting purposes makes sense even if this commit is not
    introducing any bug.

    Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-34-miquel.raynal@bootlin.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/raw/orion_nand.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/nand/raw/orion_nand.c
    +++ b/drivers/mtd/nand/raw/orion_nand.c
    @@ -180,7 +180,7 @@ static int __init orion_nand_probe(struc
    mtd->name = "orion_nand";
    ret = mtd_device_register(mtd, board->parts, board->nr_parts);
    if (ret) {
    - nand_release(nc);
    + nand_cleanup(nc);
    goto no_dev;
    }


    \
     
     \ /
      Last update: 2020-06-19 17:22    [W:4.054 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site