lkml.org 
[lkml]   [2020]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"
    From
    Date
    On 6/17/20 1:49 PM, Greg Kroah-Hartman wrote:
    > From: Wade Mealing <wmealing@redhat.com>
    >
    > Turns out that the permissions for 0400 really are what we want here,
    > otherwise any user can read from this file.
    >
    > [fixed formatting, added changelog, and made attribute static - gregkh]
    >
    > Reported-by: Wade Mealing <wmealing@redhat.com>
    > Cc: stable <stable@vger.kernel.org>
    > Fixes: f40609d1591f ("zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()")
    > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1847832
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    Reviewed-by: Steffen Maier <maier@linux.ibm.com>

    > ---
    > v2: fix read/write confusion in the changelog, thanks to Steffen for the
    > review.
    > was more specific as to the changes I made to the original patch.
    >
    > drivers/block/zram/zram_drv.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
    > index 6e2ad90b17a3..270dd810be54 100644
    > --- a/drivers/block/zram/zram_drv.c
    > +++ b/drivers/block/zram/zram_drv.c
    > @@ -2021,7 +2021,8 @@ static ssize_t hot_add_show(struct class *class,
    > return ret;
    > return scnprintf(buf, PAGE_SIZE, "%d\n", ret);
    > }
    > -static CLASS_ATTR_RO(hot_add);
    > +static struct class_attribute class_attr_hot_add =
    > + __ATTR(hot_add, 0400, hot_add_show, NULL);
    >
    > static ssize_t hot_remove_store(struct class *class,
    > struct class_attribute *attr,
    >


    --
    Mit freundlichen Gruessen / Kind regards
    Steffen Maier

    Linux on IBM Z Development

    https://www.ibm.com/privacy/us/en/
    IBM Deutschland Research & Development GmbH
    Vorsitzender des Aufsichtsrats: Matthias Hartmann
    Geschaeftsfuehrung: Dirk Wittkopp
    Sitz der Gesellschaft: Boeblingen
    Registergericht: Amtsgericht Stuttgart, HRB 243294

    \
     
     \ /
      Last update: 2020-06-18 19:15    [W:3.093 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site