Messages in this thread | | | Date | Thu, 18 Jun 2020 12:41:57 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func() |
| |
On Thu, 18 Jun 2020 01:12:37 +0200 Jann Horn <jannh@google.com> wrote:
> static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > +static ftrace_asm_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > { > +#if FTRACE_FORCE_LIST_FUNC > + return ftrace_ops_list_func; > +#else > /* > * If this is a dynamic, RCU, or per CPU ops, or we force list func, > * then it needs to call the list anyway. > */ > - if (ops->flags & (FTRACE_OPS_FL_DYNAMIC | FTRACE_OPS_FL_RCU) || > - FTRACE_FORCE_LIST_FUNC) > + if (ops->flags & (FTRACE_OPS_FL_DYNAMIC | FTRACE_OPS_FL_RCU)) > return ftrace_ops_list_func; > > return ftrace_ops_get_func(ops);
But ftrace_ops_get_func() returns ftrace_func_t type, wont this complain?
-- Steve
> +#endif > }
| |