lkml.org 
[lkml]   [2020]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] lib: fix test_hmm.c reference after free
From
Date

On 6/17/20 10:31 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Coccinelle scripts report the following errors:
>
> lib/test_hmm.c:523:20-26: ERROR: reference preceded by free on line 521
> lib/test_hmm.c:524:21-27: ERROR: reference preceded by free on line 521
> lib/test_hmm.c:523:28-35: ERROR: devmem is NULL but dereferenced.
> lib/test_hmm.c:524:29-36: ERROR: devmem is NULL but dereferenced.
>
> Fix these by using the local variable 'res' instead of devmem.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jérôme Glisse <jglisse@redhat.com>
> Cc: linux-mm@kvack.org
> Cc: Ralph Campbell <rcampbell@nvidia.com>
> ---
> lib/test_hmm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-next-20200617.orig/lib/test_hmm.c
> +++ linux-next-20200617/lib/test_hmm.c
> @@ -520,8 +520,7 @@ static bool dmirror_allocate_chunk(struc
> err_free:
> kfree(devmem);
> err_release:
> - release_mem_region(devmem->pagemap.res.start,
> - resource_size(&devmem->pagemap.res));
> + release_mem_region(res->start, resource_size(res));
> err:
> mutex_unlock(&mdevice->devmem_lock);
> return false;
>

Thanks for fixing this!
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>

\
 
 \ /
  Last update: 2020-06-18 18:22    [W:0.033 / U:1.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site