lkml.org 
[lkml]   [2020]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] driver core:Export the symbol device_is_bound
On Thu, Jun 18, 2020 at 08:45:55AM -0700, Matthias Kaehlcke wrote:
> Hi Greg,
>
> On Thu, Jun 18, 2020 at 10:14:43AM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 03, 2020 at 12:09:52AM +0530, Sandeep Maheswaram wrote:
> > > Export the symbol device_is_bound so that it can be used by the modules.
> >
> > What modules need this?
>
> drivers/usb/dwc3/dwc3-qcom.c (and probably other dwc3 'wrappers').

Why wasn't that said here? No context is not good :(

> Short summary: QCOM dwc3 support is split in two drivers, the core dwc3
> driver and the QCOM specific parts. dwc3-qcom is probed first (through
> a DT entry or ACPI), dwc3_qcom_probe() then calls of_platform_populate()
> to probe the core part. After a successful return from _populate() the
> driver assumes that the core device is fully initialized. However the
> latter is not correct, the driver core doesn't propagate errors from
> probe() to platform_populate(). The dwc3-qcom driver would use
> device_is_bound() to make sure the core device was probed successfully.

why does the dwc3-qcom driver care?

And why is the driver split in a way that requires such "broken"
structures? Why can't that be fixed instead?

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-06-18 17:59    [W:0.033 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site