lkml.org 
[lkml]   [2020]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c
    Date
    At 2020-06-18 03:10:02, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
    >It would be better to do this in the declaration block so you can change
    >the earlier two uses in this function:
    >
    >+ struct gasket_bar_data *data = &gasket_dev->bar_data[bar_num];
    >- ulong desc_bytes = driver_desc->bar_descriptions[bar_num].size;
    >+ ulong desc_bytes = data->size;
    >
    >...
    >
    >- if (driver_desc->bar_descriptions[bar_num].type != PCI_BAR) {
    >+ if (data->type != PCI_BAR) {

    `struct gasket_bar_data *data` and `driver_desc->bar_descriptions[bar_num]`
    are not the same thing as I see it. Besides, `struct gasket_bar_data`
    doesn't have a `size` field (it does have a `length_bytes` field).
    So... did I miss anything?

    --
    Zhixu Zhao
    https://github.com/zhaozhixu

    \
     
     \ /
      Last update: 2020-06-18 16:19    [W:2.927 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site