Messages in this thread | | | Subject | Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe | From | Steven Price <> | Date | Thu, 18 Jun 2020 10:28:31 +0100 |
| |
On 17/06/2020 20:57, Rob Herring wrote: > On Wed, Jun 17, 2020 at 8:36 AM Steven Price <steven.price@arm.com> wrote: >> >> On 17/06/2020 15:15, Krzysztof Kozlowski wrote: >>> On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: >>>> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> >>>> >>>> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: >>>>> There is no point to print deferred probe (and its failures to get >>>>> resources) as an error. Also there is no need to print regulator errors >>>>> twice. >>>>> >>>>> In case of multiple probe tries this would pollute the dmesg. >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>>>> Reviewed-by: Steven Price <steven.price@arm.com> >>>>> >>>>> --- >>>>> >>>>> Changes since v2: >>>>> 1. Rebase >>>>> 2. Add Steven's review >>>>> >>>>> Changes since v1: >>>>> 1. Remove second error message from calling panfrost_regulator_init() >>>>> --- >>>>> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- >>>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>>> >>> >>> Hi Rob, Tomeu and Steven, >>> >>> You're listed as maintainers for panfrost. Is anyone going to pick this >>> up? >> >> I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can >> pick it up if Rob/Tomeu are happy for me to do that. >> >>> Maybe I sent it to wrong mailing list or forgot about anything? >> >> No, there's actually a few Panfrost commits waiting, it was on my todo >> list to ask if Rob/Tomeu needed some help with merging patches. > > Please do, I haven't had the cycles for panfrost lately. > > Rob >
Ok, this patch is pushed to drm-misc-next. I'll dig through my emails for the other patches which are pending and take a look at them too.
Steve
| |