Messages in this thread | | | Date | Thu, 18 Jun 2020 10:14:43 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] driver core:Export the symbol device_is_bound |
| |
On Wed, Jun 03, 2020 at 12:09:52AM +0530, Sandeep Maheswaram wrote: > Export the symbol device_is_bound so that it can be used by the modules.
What modules need this?
> This change was suggested to solve the allmodconfig build error on adding > the patch https://lore.kernel.org/patchwork/patch/1218628/ > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> > --- > drivers/base/dd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index 9a1d940..65d16ce 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -337,6 +337,7 @@ bool device_is_bound(struct device *dev) > { > return dev->p && klist_node_attached(&dev->p->knode_driver); > } > +EXPORT_SYMBOL_GPL(device_is_bound);
If a driver needs to use this, something is really wrong with it. What happens right after this, the state could have changed?
So, no, sorry, this is not a good idea.
thanks,
greg k-h
| |