lkml.org 
[lkml]   [2020]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soc: xilinx: Fix error code in zynqmp_pm_probe()
From
Date


On 05. 06. 20 13:07, Michal Simek wrote:
> On 05. 06. 20 13:00, Dan Carpenter wrote:
>> This should be returning PTR_ERR() but it returns IS_ERR() instead.
>>
>> Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> drivers/soc/xilinx/zynqmp_power.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
>> index 31ff49fcd078b..c556623dae024 100644
>> --- a/drivers/soc/xilinx/zynqmp_power.c
>> +++ b/drivers/soc/xilinx/zynqmp_power.c
>> @@ -205,7 +205,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
>> rx_chan = mbox_request_channel_byname(client, "rx");
>> if (IS_ERR(rx_chan)) {
>> dev_err(&pdev->dev, "Failed to request rx channel\n");
>> - return IS_ERR(rx_chan);
>> + return PTR_ERR(rx_chan);
>> }
>> } else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) {
>> irq = platform_get_irq(pdev, 0);
>>
>
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Applied.
M

\
 
 \ /
  Last update: 2020-06-18 10:11    [W:0.083 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site