lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/8] Drivers: hv: vmbus: Remove the numa_node field from the vmbus_channel struct
    Date
    The field is read only in numa_node_show() and it is already stored twice
    (after a call to cpu_to_node()) in target_cpu_store() and init_vp_index();
    there is no need to "cache" its value in the channel data structure.

    Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
    ---
    drivers/hv/channel_mgmt.c | 2 --
    drivers/hv/vmbus_drv.c | 3 +--
    include/linux/hyperv.h | 1 -
    3 files changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
    index 278e392218079..36dd8b6c544a4 100644
    --- a/drivers/hv/channel_mgmt.c
    +++ b/drivers/hv/channel_mgmt.c
    @@ -702,7 +702,6 @@ static void init_vp_index(struct vmbus_channel *channel)
    * In case alloc_cpumask_var() fails, bind it to
    * VMBUS_CONNECT_CPU.
    */
    - channel->numa_node = cpu_to_node(VMBUS_CONNECT_CPU);
    channel->target_cpu = VMBUS_CONNECT_CPU;
    if (perf_chn)
    hv_set_alloced_cpu(VMBUS_CONNECT_CPU);
    @@ -719,7 +718,6 @@ static void init_vp_index(struct vmbus_channel *channel)
    continue;
    break;
    }
    - channel->numa_node = numa_node;
    alloced_mask = &hv_context.hv_numa_map[numa_node];

    if (cpumask_weight(alloced_mask) ==
    diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
    index 7e244727f5686..c3205f40d1415 100644
    --- a/drivers/hv/vmbus_drv.c
    +++ b/drivers/hv/vmbus_drv.c
    @@ -226,7 +226,7 @@ static ssize_t numa_node_show(struct device *dev,
    if (!hv_dev->channel)
    return -ENODEV;

    - return sprintf(buf, "%d\n", hv_dev->channel->numa_node);
    + return sprintf(buf, "%d\n", cpu_to_node(hv_dev->channel->target_cpu));
    }
    static DEVICE_ATTR_RO(numa_node);
    #endif
    @@ -1764,7 +1764,6 @@ static ssize_t target_cpu_store(struct vmbus_channel *channel,
    */

    channel->target_cpu = target_cpu;
    - channel->numa_node = cpu_to_node(target_cpu);

    /* See init_vp_index(). */
    if (hv_is_perf_channel(channel))
    diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
    index 738efdb194b09..690394b79d727 100644
    --- a/include/linux/hyperv.h
    +++ b/include/linux/hyperv.h
    @@ -812,7 +812,6 @@ struct vmbus_channel {
    * the earlier behavior.
    */
    u32 target_cpu;
    - int numa_node;
    /*
    * Support for sub-channels. For high performance devices,
    * it will be useful to have multiple sub-channels to support
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-17 18:48    [W:7.974 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site