lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 5/8] net: phy: mscc: 1588 block initialization
On Wed, 17 Jun 2020 15:31:24 +0200 Antoine Tenart wrote:
> +/* Two PHYs share the same 1588 processor and it's to be entirely configured
> + * through the base PHY of this processor.
> + */
> +/* phydev->bus->mdio_lock should be locked when using this function */
> +static inline int phy_ts_base_write(struct phy_device *phydev, u32 regnum,
> + u16 val)

Please don't use static inline outside of headers in networking code.
The compiler will know best what to inline and when.

> +{
> + struct vsc8531_private *priv = phydev->priv;
> +
> + WARN_ON_ONCE(!mutex_is_locked(&phydev->mdio.bus->mdio_lock));
> + return __mdiobus_write(phydev->mdio.bus, priv->ts_base_addr, regnum,
> + val);
> +}
> +
> +/* phydev->bus->mdio_lock should be locked when using this function */
> +static inline int phy_ts_base_read(struct phy_device *phydev, u32 regnum)
> +{
> + struct vsc8531_private *priv = phydev->priv;
> +
> + WARN_ON_ONCE(!mutex_is_locked(&phydev->mdio.bus->mdio_lock));
> + return __mdiobus_read(phydev->mdio.bus, priv->ts_base_addr, regnum);
> +}

\
 
 \ /
  Last update: 2020-06-17 18:33    [W:1.130 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site