Messages in this thread | | | Subject | Re: [PATCH v3 1/4] dt-bindings: nvmem: qfprom: Convert to yaml | From | "Ravi Kumar Bokka (Temp)" <> | Date | Wed, 17 Jun 2020 21:56:38 +0530 |
| |
On 6/17/2020 8:48 PM, Srinivas Kandagatla wrote: > > > On 17/06/2020 15:51, Douglas Anderson wrote: >> From: Ravi Kumar Bokka <rbokka@codeaurora.org> >> >> This switches the bindings over from txt to yaml. >> >> Signed-off-by: Ravi Kumar Bokka <rbokka@codeaurora.org> >> Signed-off-by: Douglas Anderson <dianders@chromium.org> >> --- >> >> Changes in v3: >> - Split conversion to yaml into separate patch new in v3. >> - Use 'const' for compatible instead of a 1-entry enum. >> - Changed filename to match compatible string. >> - Add #address-cells and #size-cells to list of properties. >> - Fixed up example. >> >> .../bindings/nvmem/qcom,qfprom.yaml | 45 +++++++++++++++++++ >> .../devicetree/bindings/nvmem/qfprom.txt | 35 --------------- >> 2 files changed, 45 insertions(+), 35 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml >> delete mode 100644 Documentation/devicetree/bindings/nvmem/qfprom.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml >> b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml >> new file mode 100644 >> index 000000000000..5efa5e7c4d81 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/nvmem/qcom,qfprom.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies Inc, QFPROM Efuse bindings >> + >> +maintainers: >> + - Ravi Kumar Bokka <rbokka@codeaurora.org> >> + > > Am not sure this was intentional, but the old maintainer name is totally > lost in this patch! > > Please fix this! >
Hi Srinivas, The existed qfprom dt-bindings in .txt format. I will make it as it is to merge whole content in .yaml format once confirm all the parameters with this new driver changes.
> > >> +allOf: >> + - $ref: "nvmem.yaml#" >> + >> +properties: >> + compatible: >> + const: qcom,qfprom >> + >> + reg: >> + items: >> + - description: The corrected region. >> + >> + # Needed if any child nodes are present. >> + "#address-cells": >> + const: 1 >> + "#size-cells": >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + - | >> + efuse@784000 { >> + compatible = "qcom,qfprom"; >> + reg = <0 0x00784000 0 0x8ff>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + hstx-trim-primary@1eb { >> + reg = <0x1eb 0x1>; >> + bits = <1 4>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/nvmem/qfprom.txt >> b/Documentation/devicetree/bindings/nvmem/qfprom.txt >> deleted file mode 100644 >> index 26fe878d5c86..000000000000 >> --- a/Documentation/devicetree/bindings/nvmem/qfprom.txt >> +++ /dev/null >> @@ -1,35 +0,0 @@ >> -= Qualcomm QFPROM device tree bindings = >> - >> -This binding is intended to represent QFPROM which is found in most >> QCOM SOCs. >> - >> -Required properties: >> -- compatible: should be "qcom,qfprom" >> -- reg: Should contain registers location and length >> - >> -= Data cells = >> -Are child nodes of qfprom, bindings of which as described in >> -bindings/nvmem/nvmem.txt >> - >> -Example: >> - >> - qfprom: qfprom@700000 { >> - compatible = "qcom,qfprom"; >> - reg = <0x00700000 0x8000>; >> - ... >> - /* Data cells */ >> - tsens_calibration: calib@404 { >> - reg = <0x4404 0x10>; >> - }; >> - }; >> - >> - >> -= Data consumers = >> -Are device nodes which consume nvmem data cells. >> - >> -For example: >> - >> - tsens { >> - ... >> - nvmem-cells = <&tsens_calibration>; >> - nvmem-cell-names = "calibration"; >> - }; >>
-- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.
| |