Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 05/13] fs: check FMODE_WRITE in __kernel_write | Date | Wed, 17 Jun 2020 14:59:39 +0000 |
| |
From: Linus Torvalds > Sent: 15 June 2020 17:40 > On Mon, Jun 15, 2020 at 5:13 AM Christoph Hellwig <hch@lst.de> wrote: > > > > We still need to check if the fѕ is open write, even for the low-level > > helper. > > Is there actually a way to trigger something like this? I'm wondering > if it's worth a WARN_ON_ONCE()? > > It doesn't sound sensible to have some kernel functionality try to > write to a file it didn't open for write, and sounds like a kernel bug > if this case were to ever trigger..
It's a cheap test at the top of some fairly heavy code. Failing the request will soon identify the bug.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |