Messages in this thread | | | Subject | Re: [PATCH] fs: move kernel_read_file* to its own include file | From | Scott Branden <> | Date | Tue, 16 Jun 2020 23:04:48 -0700 |
| |
Hi Greg,
On 2020-06-16 10:26 p.m., Greg Kroah-Hartman wrote: > On Tue, Jun 16, 2020 at 08:31:52PM -0700, Scott Branden wrote: >> Move kernel_read_file* to it own kernel_read_file.h include file. > That says what you did, but not _why_ you are doing it :( > I have no real opinion as to where these functions end up. I simply wish to add kernel_pread_file* support and current comment is the existing kernel_read_file* functions are in linux/fs.h and I shouldn't add more to that file.
I'd be quite happy to leave them in linux/fs.h if that is desired as well.
I can update the commit according to Christoph's comment:
"Can you also move kernel_read_* out of fs.h? That header gets pulled in just about everywhere and doesn't really need function not related to the general fs interface."
| |